Add public_user_uuid field to User model#2385
Merged
tompollard merged 3 commits intodevfrom Apr 15, 2025
Merged
Conversation
9ae996a to
6a3b692
Compare
6a3b692 to
2a7f049
Compare
Chrystinne
approved these changes
Apr 15, 2025
Collaborator
Chrystinne
left a comment
There was a problem hiding this comment.
@tompollard The code looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be helpful to have a unique field to identify user accounts. One use case for this ID is for our project to allow PhysioNet users to login to the NSTRI platform (see: #2383).
The unique ID would allow the NSTRI platform to maintain a persistent link between logins and PhysioNet users (see: #2383).
PhysioNet users can update their email, username, etc, so these fields do not meet this need. It seems weird to be sharing the primary key in our database, so instead we are creating a new
public_user_uuidfield.This pull request:
public_user_uuidto the User model