Add KHDP account unlink functionality#2569
Merged
Chrystinne merged 8 commits intodevfrom Jan 29, 2026
Merged
Conversation
tompollard
requested changes
Jan 29, 2026
Member
tompollard
left a comment
tompollard
left a comment
There was a problem hiding this comment.
Thanks Chrystinne - added some comments inline.
Collaborator
Author
Thanks for your comments, @tompollard. I've made the changes. That actually makes it more user-friendly. |
tompollard
reviewed
Jan 29, 2026
physionet-django/user/views.py
Outdated
| final_url = f"{khdp_auth_url}?{urlencode(params)}" | ||
| return redirect(final_url) | ||
|
|
||
| if request.POST.get('remove_khdp'): |
Member
There was a problem hiding this comment.
sorry, i should have picked this up before, but i think elif is better here. we only ever want request_khdp or remove_khdp so coupling them makes sense.
Collaborator
Author
There was a problem hiding this comment.
@tompollard I initially did it the way you suggested, but later changed it to match the orcid implementation. No worries, I’ll make that change
tompollard
approved these changes
Jan 29, 2026
Member
tompollard
left a comment
tompollard
left a comment
There was a problem hiding this comment.
Thanks @Chrystinne, looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the possibility to unlink a KHDP account from the user's PhysioNet profile by adding an "Unlink KHDP Account" button on the settings page.
The button is displayed conditionally when an account is already linked, mirroring the pattern used for ORCID account management.