Add "On Hold" status to editorial workflow#2574
Conversation
|
Not great to implement the form submission in multiple separate places (submitted_projects() and editor_home().) Instead, how about: Please use consistent terminology; don't use "activate" as an antonym for "park". "park" and "unpark" would be fine terms to use internally if you don't want to use "on-hold" and "not-on-hold". "activate" is I think already badly overloaded and should be avoided. |
|
Although maybe if "park" is the verb used in the console then "parked" should be the name of the attribute in ActiveProject. |
|
Thanks @bemoody, good points! I think it would be easier to switch all of the "park" terminology to "on hold". Are you okay with that? |
Sure, that sounds good. |
1c74485 to
aa08736
Compare
|
Terminology should be fixed now. I added a single view for handling the on-hold switching, and moved to the two step migration. |
bemoody
left a comment
There was a problem hiding this comment.
This looks good. An improvement would be to disable or hide the button if the user does not have permission (not a managing editor and not assigned editor of this project.)
This pull request add an
is_on_holdflag to ActiveProject that allows editors to temporarily park submissions without changing their workflow stage (requested by @lilehman):Notes for testing the new functionality: