Skip to content

Update PSLP to 0.0.4 #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZedongPeng wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update PSLP to 0.0.4 #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee63c64
update PSLP to 0.0.4 and fix the primal objective value bug
ZedongPeng Jan 4, 2026
522dc1a
update to v0.2.3
ZedongPeng Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ project(cupdlpx LANGUAGES C CXX CUDA)

set(CUPDLPX_VERSION_MAJOR 0)
set(CUPDLPX_VERSION_MINOR 2)
set(CUPDLPX_VERSION_PATCH 2)
set(CUPDLPX_VERSION_PATCH 3)

set(CUPDLPX_VERSION "${CUPDLPX_VERSION_MAJOR}.${CUPDLPX_VERSION_MINOR}.${CUPDLPX_VERSION_PATCH}")
add_compile_definitions(CUPDLPX_VERSION="${CUPDLPX_VERSION}")
Expand Down Expand Up @@ -77,7 +77,7 @@ endif()

include(FetchContent)

set(PSLP_VERSION_TAG "v0.0.3")
set(PSLP_VERSION_TAG "v0.0.4")

FetchContent_Declare(
pslp
Expand Down
4 changes: 1 addition & 3 deletions src/presolve.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,7 @@ void pslp_postsolve(cupdlpx_presolve_info_t *info,
postsolve(info->presolver,
result->primal_solution,
result->dual_solution,
result->reduced_cost,
result->primal_objective_value);
result->reduced_cost);

result->num_reduced_variables = info->presolver->reduced_prob->n;
result->num_reduced_constraints = info->presolver->reduced_prob->m;
Expand All @@ -184,7 +183,6 @@ void pslp_postsolve(cupdlpx_presolve_info_t *info,
memcpy(result->primal_solution, info->presolver->sol->x, original_prob->num_variables * sizeof(double));
memcpy(result->dual_solution, info->presolver->sol->y, original_prob->num_constraints * sizeof(double));
memcpy(result->reduced_cost, info->presolver->sol->z, original_prob->num_variables * sizeof(double));
// result->primal_objective_value = info->presolver->sol->obj; // This is a bug in PSLP. We don't need to updated primal_objective_value since offset has been updated during presolve. Therefore, the original problem and reduced problem have the same objective value.
result->presolve_time = info->presolve_time;
// if (info->presolver->stats != NULL) {
// result->presolve_stats = *(info->presolver->stats);
Expand Down