Skip to content

Conversation

@yhabib29
Copy link

@yhabib29 yhabib29 commented Mar 4, 2021

In the continuation of #148 .

It did not had time to test this Dockerfile yet (the first build took so much time).
I will confirm these changes when I have time to build the new image.
I have only tested by removing Euroc zip file, local binaries and apt cache from container, exporting new image and importing it back (7.14 GB vs 17.9GB).

Moreover, I am not a Docker expert, but according to this #minimize-the-number-of-layers each RUN/ADD/COPY creates a new layer and this #use-multi-stage-builds could be a solution.

However, the way you did this is very clear and easy to understand ! 👍

@yhabib29
Copy link
Author

yhabib29 commented Mar 4, 2021

Well I have just tried it, the Dockerfile seems to work.
After 2 hours of build, the image size is 8.43 GB.
I do not know the difference, maybe some cache subsist somewhere ...

I just had a problem with Kimera-VIO/CMakeLists.txt, cmake triggered an error while extracting ORBvoc.zip using tar command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant