transform node attributes #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanhhughes
approved these changes
May 10, 2025
Collaborator
nathanhhughes
left a comment
nathanhhughes
left a comment
There was a problem hiding this comment.
Thanks for this, I really like the idea! Technically all the poses should be Isometry3d unless you want to actually do shear and scaling on the bounding box
include/spark_dsg/bounding_box.h
Outdated
| * @brief Transform the bounding box. | ||
| * @param transform The transform to apply. | ||
| */ | ||
| void transform(const Eigen::Affine3d& transform); |
Collaborator
There was a problem hiding this comment.
Technically this should be an Eigen::Isometry3d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.