Skip to content

add missing rosdeps for minimal install#56

Merged
nathanhhughes merged 1 commit intomainfrom
fix/rosdep
Aug 11, 2025
Merged

add missing rosdeps for minimal install#56
nathanhhughes merged 1 commit intomainfrom
fix/rosdep

Conversation

@nathanhhughes
Copy link
Collaborator

Fixes the fact that boost isn't installed with a barebones ros install

Copy link
Collaborator

@Schmluk Schmluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I think you mentioned this before, but is there still a reason to support boost fs over std::fs?

@nathanhhughes
Copy link
Collaborator Author

but is there still a reason to support boost fs over std::fs?

No, I used to be wary of std::filesystem support being available in the standard library, but now it's pretty universally supported so I only use the stl version.

The boost usage is actually tied to the external plugins because I didn't want to roll my own wrapper around dlopen (e.g. here) but could be an easy dependency to drop if we wanted to

@nathanhhughes nathanhhughes merged commit ba9b042 into main Aug 11, 2025
1 check passed
@nathanhhughes nathanhhughes deleted the fix/rosdep branch August 11, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants