use node interfaces instead of pure node#57
Merged
nathanhhughes merged 2 commits intomainfrom Aug 15, 2025
Merged
Conversation
Schmluk
approved these changes
Aug 15, 2025
Collaborator
Schmluk
left a comment
Schmluk
left a comment
There was a problem hiding this comment.
LGTM!
Few minor things:
- Would be nice to test on Jazzy, otherwise good to go!
- Do the demos build + run?
- Do docs need updating?
Collaborator
Author
|
Confirmed it builds on Jazzy and the demo runs on both Humble and Jazzy. The change should hopefully be transparent to whoever uses the server (passing a full node to the constructor still works) and I didn't see anything in the docs that needed to be updated |
Collaborator
|
Many thanks! Looks much cleaner! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Schmluk ran into a case where I wanted the dynamic configs but didn't have a pointer to the underlying node, so refactored the server to use the node interfaces. This works on ROS2 Humble (unlike Ianvs) and hopefully also Jazzy (which I'm going to test soon)