Merged
Conversation
Schmluk
approved these changes
Sep 15, 2025
Collaborator
Schmluk
left a comment
Schmluk
left a comment
There was a problem hiding this comment.
Looks great! Many thanks for tracking this down!
RE storing 'unset' types: I think the string value reflecting the current state (as is now as far as I can tell) makes most sense, keeping the type of old configs around seems like unintuitive behavior that should probably be externally tracked if interesting to the user?
Collaborator
Author
|
Thanks! I guess if we notice a need for it we can implement something, yeah |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found the actual bug (type was only getting propagated if the config was set). Technically we don't need to use the
kUninitializedConfigTypeconstant when the config isn't set, idk if it's better to have that or whatever the parsed type string was (I could see both being useful)There's some semi-unrelated changes to cmake (did some of this with a really new cmake version that was giving me deprecation warnings about boost) and pre-commit (couldn't get pylint to work on 24.04) that I'm happy to touch up if it seems crucial