Add and use Adobe Fonts in TIMDEX UI #234
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer
To align with our brand guidelines, and the branding changes we've made to the Wordpress homepage, we need to update TIMDEX UI / USE UI to use Neue Haas Grotesk for a typeface.
This work implements Adobe Fonts and sets style overrides for the
textanddisplayversions of the font for USE UI. To accomplish this, new variables were created or adjusted for font family, font-weight, and line-height values to do some basic typesetting.There are still some headings being defined with too much specificity upstream in the theme gem that I will override more tactically when work is underway on content.
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.
Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing