Skip to content

Conversation

@jazairi
Copy link
Contributor

@jazairi jazairi commented Oct 20, 2025

Why these changes are being introduced:

In TIMDEX UI, titles linked to full record views. That feature is not currently implemented in USE UI.

Relevant ticket(s):

How this addresses that need:

This updates TIMDEX title links to use the source_link field.

Side effects of this change:

When developing TIMDEX UI, we decided not to test any view logic. I've continued that practice here, with some apprehension. (We've already missed a bug in the view while developing USE, which might have been avoided with more robust integration testing.) Not exactly a side effect, but perhaps a topic for future discussion.

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

N/A

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@coveralls
Copy link

coveralls commented Oct 20, 2025

Pull Request Test Coverage Report for Build 18685707699

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 98.293%

Files with Coverage Reduction New Missed Lines %
app/helpers/record_helper.rb 2 97.7%
Totals Coverage Status
Change from base Build 18603777561: 0.1%
Covered Lines: 806
Relevant Lines: 820

💛 - Coveralls

@mitlib mitlib temporarily deployed to timdex-ui-pi-use-99-tit-efx3ay October 20, 2025 19:55 Inactive
@JPrevost JPrevost self-assigned this Oct 21, 2025
@jazairi jazairi temporarily deployed to timdex-ui-pi-use-99-tit-efx3ay October 21, 2025 13:37 Inactive
@jazairi jazairi requested a review from JPrevost October 21, 2025 13:37
Why these changes are being introduced:

In TIMDEX UI, titles linked to full record views. That feature is not
currently implemented in USE UI.

Relevant ticket(s):

* [USE-99](https://mitlibraries.atlassian.net/browse/USE-99)

How this addresses that need:

This updates TIMDEX title links to use the `source_link` field.

Side effects of this change:

When developing TIMDEX UI, we decided not to test any view logic. I've
moved the logic in this change to the Search Helper in order to test it,
but we may want to discuss whether to revisit integration testing in
USE UI.
@jazairi jazairi force-pushed the use-99-title-links branch from 06704be to f85e33b Compare October 21, 2025 14:15
@jazairi jazairi merged commit 0c0f13f into main Oct 21, 2025
3 of 4 checks passed
@jazairi jazairi deleted the use-99-title-links branch October 21, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants