Move tab filters to search form

[jazairi]

Why these changes are being introduced:

UXWS would like the search tabs to display at the
bottom of the header, below the search form.

Relevant ticket(s):

• USE-147

How this addresses that need:

This moves the tabs to a partial, which is then rendered in the search form if results are present. No additional conditional logic is required, because the form itself is rendered only if the GeoData feature is not enabled.

Side effects of this change:

None.

Developer

Accessibility

• ANDI or WAVE has been run in accordance to our guide.
• This PR contains no changes to the view layer.
• New issues flagged by ANDI or WAVE have been resolved.
• New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
• No new accessibility issues have been flagged.

New ENV

• All new ENV is documented in README.
• All new ENV has been added to Heroku Pipeline, Staging and Prod.
• ENV has not changed.

Approval beyond code review

• UXWS/stakeholder approval has been confirmed.
• UXWS/stakeholder review will be completed retroactively.
• UXWS/stakeholder review is not needed.

Additional context needed to review

Please confirm that tabs continue not to show in GeoData.

Code Reviewer

Code

• I have confirmed that the code works as intended.
• Any CodeClimate issues have been fixed or confirmed as
  added technical debt.

Documentation

• The commit message is clear and follows our guidelines
  (not just this pull request message).
• The documentation has been updated or is unnecessary.
• New dependencies are appropriate or there were no changes.

Testing

• There are appropriate tests covering any new functionality.
• No additional test coverage is required.

[coveralls]

Pull Request Test Coverage Report for Build 18952428765

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 98.284%

---

Totals
Change from base Build 18945862716:	0.0%
Covered Lines:	859
Relevant Lines:	874

---

💛 - Coveralls

[matt-bernhardt]

When I activate the geodata feature on the review app, I still don't see the tab partial - so that seems to be okay.

+1 to having the tabs be in a partial, that feels better. While I wonder about the eventual naming convention we're going to use, and how easy it will be to adopt that terminology for things like tab names and URL anchors, I don't see a better choice available to us right now.