Skip to content

Conversation

@djanelle-mit
Copy link
Contributor

@djanelle-mit djanelle-mit commented Nov 10, 2025

Developer

This work updates USE UI result type tabs to match designs. This includes added hover and focus states, styling an active tab, and matching overall layout. Markup for tabs was adjusted to be a navigation bar.

NOT included in this work:

  • Responsive behavior. That will need to come in a future ticket if we add more than 2 tabs
  • Adding aria-current attribute. This will be done in USE-180
Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@mitlib mitlib temporarily deployed to timdex-ui-pi-use-61-tab-n8vlor November 10, 2025 17:00 Inactive
@mitlib mitlib temporarily deployed to timdex-ui-pi-use-61-tab-n8vlor November 10, 2025 17:27 Inactive
Copy link
Member

@matt-bernhardt matt-bernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@djanelle-mit djanelle-mit merged commit 63524f1 into main Nov 10, 2025
5 checks passed
@djanelle-mit djanelle-mit deleted the use-61-tabs branch November 10, 2025 17:41
@coveralls
Copy link

Pull Request Test Coverage Report for Build 19240274816

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.865%

Totals Coverage Status
Change from base Build 19179702786: 0.0%
Covered Lines: 871
Relevant Lines: 890

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants