Skip to content

Conversation

@djanelle-mit
Copy link
Contributor

@djanelle-mit djanelle-mit commented Nov 19, 2025

Developer

This work styles the results list to match high fidelity designs. This work includes:

  • Static text for eyebrows
  • Splitting styles off to specifically override USE results without affecting GEO
  • Styling buttons in results
  • Updating styles for contributors and highlights lists

This work does not include:

  • Dynamic eyebrow text
  • Renaming buttons/links in results
Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@mitlib mitlib temporarily deployed to timdex-ui-pi-use-161-iwp4ym68q November 19, 2025 19:42 Inactive
@mitlib mitlib temporarily deployed to timdex-ui-pi-use-161-iwp4ym68q November 19, 2025 21:08 Inactive
@coveralls
Copy link

coveralls commented Nov 19, 2025

Pull Request Test Coverage Report for Build 19541268977

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.023%

Totals Coverage Status
Change from base Build 19514453678: 0.0%
Covered Lines: 942
Relevant Lines: 961

💛 - Coveralls

@mitlib mitlib temporarily deployed to timdex-ui-pi-use-161-iwp4ym68q November 19, 2025 21:12 Inactive
@mitlib mitlib temporarily deployed to timdex-ui-pi-use-161-iwp4ym68q November 19, 2025 21:55 Inactive
https: //mitlibraries.atlassian.net/browse/USE-161
Co-Authored-By: djanelle-mit <[email protected]>
@JPrevost JPrevost temporarily deployed to timdex-ui-pi-use-161-iwp4ym68q November 20, 2025 15:02 Inactive
@JPrevost JPrevost self-assigned this Nov 20, 2025
@djanelle-mit djanelle-mit merged commit f5168a2 into main Nov 20, 2025
5 checks passed
@djanelle-mit djanelle-mit deleted the use-161 branch November 20, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants