USE-188: Responsive behavior for tab bar #289
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer
Implements responsive behavior for our tab bar. When the screen is too narrow, a "more" button is created with an overflow menu beneath it.
This work also includes final names, approved by UXWS, for our tabs.
Notable includes in this work:
lielements were clicked. It now only fires when a link is clicked.<select>dropdown menus up and down keys are how folks navigate, but because this feels like a navigation menu, where tab is typically how folks navigate, it felt right to keep it that way.Accessibility
New ENV
Approval beyond code review
Additional context needed to review
E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.
Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing