fix generation batching and single process accelerator bugs#110
Open
adistomar wants to merge 1 commit intoML-GSAI:mainfrom
Open
fix generation batching and single process accelerator bugs#110adistomar wants to merge 1 commit intoML-GSAI:mainfrom
adistomar wants to merge 1 commit intoML-GSAI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two things:
generate.py, the state tensorxcontaining the prompt as well as the masked and unmasked tokens had a hardcoded batch size of 1, meaning that the user cannot perform batching. Fix: set first dim ofxtoprompt.shape[0]during initializationeval_llada.py, if the # of processes is 1 (for ex. in single GPU case), thenself.acceleratoris set toNone. In this scenario, performingself.accelerator.wait_for_everyonewill cause an error. Fix: add a check for if the variable isNone