feat: add unit tests for sympy_to_prefix utility #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the sympy_to_prefix logic in utils/ didn't have any dedicated tests, so I added some basic coverage to make sure math expressions are parsing correctly before they hit the model .
Changes:
Added test_prefix.py using unittest.
Covers standard arithmetic (add, mul) and nested stuff like sin(x+y) or exp.
Verified the format_integer edge cases (e.g., how it handles sp.Integer(42)).
Ran this locally with python -m unittest and everything is passing. Good to have this as a safety net for the regression pipeline.