Skip to content

Substructural filters conditions#475

Merged
j-adamczyk merged 10 commits intomasterfrom
substructural_filters_conditions
Jul 29, 2025
Merged

Substructural filters conditions#475
j-adamczyk merged 10 commits intomasterfrom
substructural_filters_conditions

Conversation

@j-adamczyk
Copy link
Member

@j-adamczyk j-adamczyk commented Jul 27, 2025

Changes

Adds condition names for substructural filters, closes #459. Required a bit of refactoring and introducing a new base class, but also reduced a lot of repeated code in tests.

Checklist before requesting a review

  • Docstrings added/updated in public functions and classes
  • Tests added, reasonable test coverage (at least ~90%, make test-coverage)
  • Sphinx docs added/updated and render properly (make docs and see docs/_build/index.html)

@j-adamczyk j-adamczyk requested a review from my-alaska July 29, 2025 17:21
@j-adamczyk j-adamczyk merged commit 693d4ea into master Jul 29, 2025
13 checks passed
@j-adamczyk j-adamczyk deleted the substructural_filters_conditions branch July 29, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add condition names for filters

2 participants