Skip to content

Optimize bulk distances computation#488

Merged
j-adamczyk merged 17 commits intomasterfrom
scipy_sparse_distances
Sep 24, 2025
Merged

Optimize bulk distances computation#488
j-adamczyk merged 17 commits intomasterfrom
scipy_sparse_distances

Conversation

@j-adamczyk
Copy link
Copy Markdown
Member

@j-adamczyk j-adamczyk commented Sep 22, 2025

Changes

Add test of optimized distances.

Checklist before requesting a review

  • Docstrings added/updated in public functions and classes
  • Tests added, reasonable test coverage (at least ~90%, make test-coverage)
  • Sphinx docs added/updated and render properly (make docs and see docs/_build/index.html)

@mjste
Copy link
Copy Markdown
Collaborator

mjste commented Sep 22, 2025

Why changing floats to ints? 1.0 -> 1

Copy link
Copy Markdown
Collaborator

@mjste mjste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split into smaller, isolated changes

This was referenced Sep 23, 2025
@j-adamczyk j-adamczyk requested a review from mjste September 23, 2025 14:31
@j-adamczyk j-adamczyk merged commit 3436a2c into master Sep 24, 2025
13 checks passed
@j-adamczyk j-adamczyk deleted the scipy_sparse_distances branch September 24, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants