Skip to content

Fix datasets typing#504

Merged
j-adamczyk merged 1 commit intomasterfrom
fix_datasets_typing
Nov 22, 2025
Merged

Fix datasets typing#504
j-adamczyk merged 1 commit intomasterfrom
fix_datasets_typing

Conversation

@j-adamczyk
Copy link
Copy Markdown
Member

Changes

There was a typo in typing of return type in datasets loading. This PR fixes that.

Checklist before requesting a review

  • Docstrings added/updated in public functions and classes
  • Tests added, reasonable test coverage (at least ~90%, make test-coverage)
  • Sphinx docs added/updated and render properly (make docs and see docs/_build/index.html)

Copy link
Copy Markdown
Collaborator

@mjste mjste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we somehow automate checking type hints?

@j-adamczyk j-adamczyk merged commit 5eb50a0 into master Nov 22, 2025
13 checks passed
@j-adamczyk j-adamczyk deleted the fix_datasets_typing branch November 22, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants