Fixed random_state parameter documentation and implementation#532
Open
deepakdamera wants to merge 1 commit intoMLCIL:masterfrom
Open
Fixed random_state parameter documentation and implementation#532deepakdamera wants to merge 1 commit intoMLCIL:masterfrom
deepakdamera wants to merge 1 commit intoMLCIL:masterfrom
Conversation
- Removed random_state from BaseFingerprintTransformer and BaseSubstructureFingerprint - Added random_state parameter to MAPFingerprint, MHFPFingerprint, and SECFPFingerprint - Added missing documentation for random_state in affected classes - Removed random_state from E3FPFingerprint as it doesn't use randomness - Updated FingerprintEstimatorRandomizedSearch documentation
deepakdamera
requested review from
j-adamczyk,
mjste and
my-alaska
as code owners
deepakdamera
changed the title
j-adamczyk
requested changes
Mar 22, 2026
Member
j-adamczyk
left a comment
j-adamczyk
left a comment
There was a problem hiding this comment.
Please use the provided PR template and headers, and check all the checkboxes making sure they are implemented.
Pre-commit in tests failed, are your pre-commit hooks running properly?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #531
Implemented fix for the issue described. All tests pass.
Checklist before requesting a review
make test-coverage)make docsand seedocs/_build/index.html)