Changed pretty_date to handle empty input argument#851
Merged
bradchoate merged 3 commits intoMLTSHP:robust-pretty-printfrom Oct 24, 2025
Merged
Changed pretty_date to handle empty input argument#851bradchoate merged 3 commits intoMLTSHP:robust-pretty-printfrom
bradchoate merged 3 commits intoMLTSHP:robust-pretty-printfrom
Conversation
…, though was getting an fatal error for what should be a minor data quality issue.
bradchoate
reviewed
Sep 6, 2025
lib/utilities.py
Outdated
| """ | ||
| Expects a datetime in utc. | ||
| """ | ||
| if not time: |
Collaborator
There was a problem hiding this comment.
Let's remove the False default value since this argument is required. I suppose it's possible for a None value to be passed in if a row has a NULL value for a sourced created_at column (it appears some tables permit NULL values for the column, but the _set_dates routine should be assigning a proper initial datetime value). I suppose an empty string is fine output for nonsensical inputs; we're doing that for the case where the supplied datetime is in the future.
expects one). Renamed function parameter 'time' to avoid any clashes with time std module. Added created_at value to admin user in test database to avoid original issue.
Contributor
Author
|
@bradchoate removed default None as suggested. Also added a created_at value for the default admin user in the test database. This unexpected null can cause issues in other places so best to patch it up even if we have fixed pretty_date. |
bradchoate
approved these changes
Oct 24, 2025
bradchoate
added a commit
that referenced
this pull request
Oct 24, 2025
* Added an empty arg check to pretty_date. Should probably never happen, though was getting an fatal error for what should be a minor data quality issue. * Based on PR feedback removed default None value (function typically expects one). Renamed function parameter 'time' to avoid any clashes with time std module. Added created_at value to admin user in test database to avoid original issue. Co-authored-by: James Beard <james@smallsaucepan.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing an empty argument to pretty_date would cause a fatal error. Though this should probably never occur in practice, we can handle any poor data more robustly.