[Feature] Comments & mentions in chats #702
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CREDO23 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on 0d2a2f8..4792fb7
| Severity | Location | Issue | Delete |
|---|---|---|---|
 |
surfsense_backend/app/services/chat_comments_service.py:593 | Lazy loading error with async session |  |
✅ Files analyzed, no issues (7)
• docs/comments-implementation-guide.md
• surfsense_backend/alembic/versions/66_add_chat_comments_table.py
• surfsense_backend/alembic/versions/67_add_chat_comment_mentions_table.py
• surfsense_backend/app/db.py
• surfsense_backend/app/routes/__init__.py
• surfsense_backend/app/routes/chat_comments_routes.py
• surfsense_backend/app/utils/chat_comments.py
CREDO23
force-pushed
the
sur-90-feat-comments-in-chats
branch
from
c0ce7ab to
9d11446
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change Type
Testing Performed
Checklist
High-level PR Summary
This PR implements a Google Docs-style commenting system for shared AI chat responses, allowing users to add comments and replies to AI-generated messages with @mention support. The implementation includes database migrations for
chat_commentsandchat_comment_mentionstables, new permissions (COMMENTS_CREATE,COMMENTS_READ,COMMENTS_DELETE), and a complete backend API supporting comment CRUD operations, mention parsing and rendering, and read/unread tracking. Comments are limited to AI responses only and support one level of nesting (comments can have replies, but replies cannot have further replies). The feature includes proper permission checks based on search space membership and role-based access control.⏱️ Estimated Review Time: 30-90 minutes
💡 Review Order Suggestion
docs/comments-implementation-guide.mdsurfsense_backend/alembic/versions/66_add_chat_comments_table.pysurfsense_backend/alembic/versions/67_add_chat_comment_mentions_table.pysurfsense_backend/app/db.pysurfsense_backend/app/schemas/chat_comments.pysurfsense_backend/app/utils/chat_comments.pysurfsense_backend/app/services/chat_comments_service.pysurfsense_backend/app/routes/chat_comments_routes.pysurfsense_backend/app/routes/__init__.py