HEVC sample entry parsing, LHEVC support, and build-system modernisation#61
Merged
HEVC sample entry parsing, LHEVC support, and build-system modernisation#61
Conversation
podborski
changed the title
- Add ISOBMFF_BUILD_LIB_ONLY option (default OFF for backward compatibility) - Skip submodule checks and tool builds when building library only - Enables fast integration without HM/DRC dependencies (~30s vs 5-10min)
BREAKING CHANGE: Build artifacts now go to build directory by default instead of source tree (lib/, bin/) - Better aligns with CMake best practices and modern workflows - Cleaner integration when used as a subproject via add_subdirectory() - Prevents source tree pollution with build artifacts - Use -DSET_CUSTOM_OUTPUT_DIRS=ON to restore previous behavior
Member
Author
|
Hi @jeanlf , Cyril recommended to check with you. Are you ok with the changes proposed in this PR? |
podborski
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces comprehensive improvements to HEVC handling and modernises the build configuration.
Functional changes
hvcCsyntax elements.lhvCsupport, including parsing and NAL unit extraction.ISOGetHEVCNALUs()API to extract all HEVC NAL units in Annex B format, with selectable extraction modes (hvcC,lhvC, or both).ISOGetRESVOriginalFormattoISOGetOriginalFormatand extend support toencv/resv.Build and infrastructure
ISOBMFF_BUILD_LIB_ONLYoption to allow library-only builds without tools, tests, or submodules.SET_CUSTOM_OUTPUT_DIRSoption (default OFF) to align with modern CMake output directory practices.LIBISOMEDIAFILE_STRICT_WARNINGSoption (ON by default).Maintenance