Skip to content

Conversation

@remlapmot
Copy link
Contributor

  • Fixed a bug in format_data() when the log_pval argument was set to TRUE.
    The specified p-value column is now used (thanks to @luddeluddis)
  • Amend references to MR-Base to OpenGWAS

Closes #586

@codecov
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 38.68%. Comparing base (7009a54) to head (93fd303).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
R/read_data.R 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #588       +/-   ##
===========================================
- Coverage   48.80%   38.68%   -10.12%     
===========================================
  Files          31       31               
  Lines        5250     5250               
===========================================
- Hits         2562     2031      -531     
- Misses       2688     3219      +531     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remlapmot remlapmot merged commit efc30d0 into MRCIEU:master Feb 5, 2025
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Incorrect P-value handling in format_data function when using custom P-value column names with log_pval=TRUE

1 participant