-
Notifications
You must be signed in to change notification settings - Fork 196
Introduce magic_enum for enum <--> string conversion #3275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
daljit46
wants to merge
21
commits into
dev
Choose a base branch
from
magic_enum
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
f950146
Add magic_enum library in CMake
daljit46 c69c1cb
Add wrapper functions for enum <--> string conversion
daljit46 ca8cdea
Replace string with enums in cmd code
daljit46 87ad065
Address clang-tidy warnings
daljit46 333ba84
Add a new helper to concatenate enums as a string
daljit46 ff14df8
Add template version of type_choice()
daljit46 cbc3663
Add helper function get_option_choice for enums
daljit46 885b8c6
Use enum templated type_choice() for commands + review feedback
daljit46 470133d
Rename lower_case_enums -> lower_case_enum_names
daljit46 8489bad
Add comments for new functions in mrtrix.h
daljit46 8787cc0
Use switch instead of if statement for -weighted option
daljit46 f769a30
Address clang-tidy const correctness warning
daljit46 baf6de0
Fix typo
daljit46 1fe17bc
Fix formatting
daljit46 4f05359
Fix compilation errors
daljit46 c0935dd
mrdegibbs: change -mode to use integers rather than choices
daljit46 8797ef7
mtnormalise: change -number to use integers rather than choices
daljit46 770f4ec
peaksconvert: use enums instead of strings for choices
daljit46 0ec0ac9
Change join_enum delimiter to comma followed by space
daljit46 a977dd1
Update documentation following CLI changes
daljit46 511fd5e
Move enum functions to new namespace and file
daljit46 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.