Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| SelectedAdapter request_adapter_by_index(const wgpu::InstanceDescriptor &instance_descriptor, | ||
| const wgpu::RequestAdapterOptions &adapter_options, | ||
| const uint32_t adapter_index) { | ||
| dawn::native::Instance dawn_instance(&instance_descriptor); |
There was a problem hiding this comment.
warning: variable 'dawn_instance' of type 'dawn::native::Instance' can be declared 'const' [misc-const-correctness]
| dawn::native::Instance dawn_instance(&instance_descriptor); | |
| dawn::native::Instance const dawn_instance(&instance_descriptor); |
| // Force the strides to match the memory layout written by download_texture: | ||
| // Channel (if present) is fastest, then X, then Y, then Z. | ||
| for (size_t i = 0; i < texture_dims; ++i) { | ||
| source_header.stride(i) = has_channel_axis ? i + 2 : i + 1; |
There was a problem hiding this comment.
warning: narrowing conversion from 'size_t' (aka 'unsigned long') to signed type 'ssize_t' (aka 'long') is implementation-defined [bugprone-narrowing-conversions]
source_header.stride(i) = has_channel_axis ? i + 2 : i + 1;
^| // Force the strides to match the memory layout written by download_texture: | ||
| // Channel (if present) is fastest, then X, then Y, then Z. | ||
| for (size_t i = 0; i < texture_dims; ++i) { | ||
| source_header.stride(i) = has_channel_axis ? i + 2 : i + 1; |
There was a problem hiding this comment.
warning: narrowing conversion from 'size_t' (aka 'unsigned long') to signed type 'ssize_t' (aka 'long') is implementation-defined [bugprone-narrowing-conversions]
source_header.stride(i) = has_channel_axis ? i + 2 : i + 1;
^| }; | ||
| context.copy_texture_to_texture(src_texture, dst_texture, copy_info); | ||
|
|
||
| std::vector<float> downloaded_data(dst_initial.size(), 0.0F); |
There was a problem hiding this comment.
warning: variable 'downloaded_data' is not initialized [cppcoreguidelines-init-variables]
| std::vector<float> downloaded_data(dst_initial.size(), 0.0F); | |
| std::vector<float> downloaded_data = 0(dst_initial.size(), 0.0F); |
| } | ||
| } | ||
|
|
||
| TEST_F(GPUTest, CopyTextureToTextureWithOffsetsOutOfRangeThrows) { |
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
| TEST_F(GPUTest, CopyTextureToTextureWithOffsetsOutOfRangeThrows) { | |
| TEST_F(GPUTest /*unused*/, CopyTextureToTextureWithOffsetsOutOfRangeThrows /*unused*/) { |
1 participant
This PR contains some small additions to the GPU API:
MR::Imageinstances.