Open
Conversation
|
@dbogdanov Can this be merged? |
Author
|
it's been quite some time since I created this PR and I'm not entirely sure whether the extracted dependencies will all work as they used to. however I don't see the point in updating this PR if it's just going to sit. if a maintainer @'s me asking to update it with a plan to merge I will. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30, fixes #32, fixes #33
The misconception in the linked issue description is that
depends_on "numpy"should install numpy bindings, whichessentiarequires. However, homebrew's currentnumpyno longer supportspython3.9, which is why the build was failing to find numpy. That is also why runningpython3.9 -m pip install numpywill allowessentiato build properly, although it is generally not recommended to install python modules to a homebrew python distribution manually.Instead, I've done the following:
brew extract --version=0.29.30 libcython mtg/essentialibcython(from homebrew) that uses python3.9python3.9brew extract --version=1.23.3 numpy mtg/essentianumpy(from homebrew) that uses python3.9python3.9, and use this tap'slibcythonhomebrew-core/numpyconflictpython3.9 -> pythonmanuallyNote that the formulae i've extracted from
homebrew-coreare just the most recent versions that haddepends_on "python@3.9". Newer versions oflibcythonandnumpysupport 3.9 but I didn't want to extract the current version and have to backport it in case there were other changes.slight note: i think that
--with-gaiabindings might be broken/not fully working, since that formula usespython@3.8. I can submit a pr later that will update that.