Łukasz Krulik 228780#3
Open
FawBiotechnologist wants to merge 12 commits intoMTO-2022-pt:FawBiotechnologistfrom
Open
Łukasz Krulik 228780#3FawBiotechnologist wants to merge 12 commits intoMTO-2022-pt:FawBiotechnologistfrom
FawBiotechnologist wants to merge 12 commits intoMTO-2022-pt:FawBiotechnologistfrom
Conversation
added 10 commits
April 8, 2022 14:31
…eption added orderExpiredExpectingCancelledState test
radamuspl
requested changes
Apr 22, 2022
| public void confirm() { | ||
| requireState(State.SUBMITTED); | ||
| long hoursElapsedAfterSubmittion = subbmitionDate.until(LocalDateTime.now(), ChronoUnit.HOURS); | ||
| long hoursElapsedAfterSubmittion = subbmitionDate.until((testPurposesDatatime == null) ? LocalDateTime.now() : testPurposesDatatime, ChronoUnit.HOURS); |
Contributor
There was a problem hiding this comment.
to nie jest dobre rozwiązanie wprowadza pan logikę wyliczanie daty "pod testy". Nie chodziło o to, aby do konstruktora przekazać "przesuniętą datę" (albo null - co oznacza brak przesunięcia). Zamówienie powinno wyliczać czas zgodnie z założeniami, ale być zależna od "zegara", który w testach można "zamockować"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.