Skip to content

[DOP-23149] Replace python-jose with pyjwt#137

Merged
dolfinus merged 2 commits intodevelopfrom
bugfix/DOP-23149
Dec 25, 2024
Merged

[DOP-23149] Replace python-jose with pyjwt#137
dolfinus merged 2 commits intodevelopfrom
bugfix/DOP-23149

Conversation

@dolfinus
Copy link
Member

Change Summary

python-jose last release version was in 2021. Replace it with a modern library.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus marked this pull request as ready for review December 24, 2024 15:59
@codecov
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.35%. Comparing base (b9d33ff) to head (029cf05).
Report is 130 commits behind head on develop.

Files with missing lines Patch % Lines
data_rentgen/server/utils/jwt.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #137   +/-   ##
========================================
  Coverage    92.35%   92.35%           
========================================
  Files          172      172           
  Lines         3819     3819           
  Branches       265      265           
========================================
  Hits          3527     3527           
  Misses         230      230           
  Partials        62       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dolfinus dolfinus merged commit bf103a0 into develop Dec 25, 2024
9 of 10 checks passed
@dolfinus dolfinus deleted the bugfix/DOP-23149 branch December 25, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants