Skip to content

[DOP-22401] Small fixes and optimizations#150

Merged
dolfinus merged 3 commits intodevelopfrom
feature/DOP-22401
Feb 4, 2025
Merged

[DOP-22401] Small fixes and optimizations#150
dolfinus merged 3 commits intodevelopfrom
feature/DOP-22401

Conversation

@dolfinus
Copy link
Member

@dolfinus dolfinus commented Feb 3, 2025

Change Summary

  • Do not call dto.merge(new_dto) if dto and new_dto are the same object. This is small optimization, used mostly for locations and datasets, as they are reused as nested fields for other DTOs (inputs, outputs and so on).
  • Simplify s bit logic for extract_dataset_and_symlinks - do not call extract_dataset multiple times for the same input.
  • SQLAlchemy shows warning about unknown property server_defaults, it should be server_default

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@codecov
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.68%. Comparing base (eadb990) to head (b69a036).
Report is 141 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #150      +/-   ##
===========================================
+ Coverage    92.66%   92.68%   +0.01%     
===========================================
  Files          177      177              
  Lines         3874     3880       +6     
  Branches       267      268       +1     
===========================================
+ Hits          3590     3596       +6     
  Misses         222      222              
  Partials        62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dolfinus dolfinus marked this pull request as ready for review February 4, 2025 07:38
@dolfinus dolfinus merged commit c5dfe66 into develop Feb 4, 2025
12 checks passed
@dolfinus dolfinus deleted the feature/DOP-22401 branch February 4, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants