[DOP-22401] Small fixes and optimizations#150
Merged
Conversation
a793f0e to
eb40e8e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #150 +/- ##
===========================================
+ Coverage 92.66% 92.68% +0.01%
===========================================
Files 177 177
Lines 3874 3880 +6
Branches 267 268 +1
===========================================
+ Hits 3590 3596 +6
Misses 222 222
Partials 62 62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eb40e8e to
b69a036
Compare
TiGrib
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
dto.merge(new_dto)ifdtoandnew_dtoare the same object. This is small optimization, used mostly for locations and datasets, as they are reused as nested fields for other DTOs (inputs, outputs and so on).extract_dataset_and_symlinks- do not callextract_datasetmultiple times for the same input.server_defaults, it should beserver_defaultRelated issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rstfile added describing change(see CONTRIBUTING.rst for details.)