Skip to content

[DOP-22735] - fix multiple proxyUrl for spark#154

Merged
TiGrib merged 5 commits intodevelopfrom
feature/DOP-22735
Feb 5, 2025
Merged

[DOP-22735] - fix multiple proxyUrl for spark#154
TiGrib merged 5 commits intodevelopfrom
feature/DOP-22735

Conversation

@TiGrib
Copy link
Contributor

@TiGrib TiGrib commented Feb 4, 2025

Change Summary

  • add spliting OpenLineageSparkApplicationDetailsRunFacet.proxyUrl by ','
  • update tests

Related issue number

[DOP-22735]

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@TiGrib TiGrib self-assigned this Feb 4, 2025
@TiGrib TiGrib requested a review from dolfinus February 4, 2025 10:01
@codecov
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.68%. Comparing base (868e822) to head (da66b44).
Report is 137 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #154   +/-   ##
========================================
  Coverage    92.68%   92.68%           
========================================
  Files          177      177           
  Lines         3880     3882    +2     
  Branches       268      269    +1     
========================================
+ Hits          3596     3598    +2     
  Misses         222      222           
  Partials        62       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@dolfinus dolfinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add news entry to docs/changelog/next_release

@TiGrib TiGrib merged commit 9862b60 into develop Feb 5, 2025
13 checks passed
@TiGrib TiGrib deleted the feature/DOP-22735 branch February 5, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants