Skip to content

[DOP-22578] Change response schema of GET /datasets#161

Merged
dolfinus merged 1 commit intodevelopfrom
feature/DOP-22578-datasets
Feb 13, 2025
Merged

[DOP-22578] Change response schema of GET /datasets#161
dolfinus merged 1 commit intodevelopfrom
feature/DOP-22578-datasets

Conversation

@dolfinus
Copy link
Member

@dolfinus dolfinus commented Feb 12, 2025

Change Summary

Changed the response schema of GET /datasets to match other endpoints (#158, #159, #160, #162). For now there is no statistics for dataset, but it can be added later (e.g. inputs/outputs stats within last day/week/month) without breaking backward compatibility.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Feb 12, 2025
@dolfinus dolfinus force-pushed the feature/DOP-22578-datasets branch from 91442d2 to 9f1eb00 Compare February 12, 2025 10:44
@dolfinus dolfinus marked this pull request as ready for review February 12, 2025 10:51
@codecov
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.15%. Comparing base (5e52684) to head (b521950).
Report is 135 commits behind head on develop.

Files with missing lines Patch % Lines
data_rentgen/server/services/dataset.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #161   +/-   ##
========================================
  Coverage    93.14%   93.15%           
========================================
  Files          183      184    +1     
  Lines         4188     4208   +20     
  Branches       281      281           
========================================
+ Hits          3901     3920   +19     
- Misses         225      226    +1     
  Partials        62       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dolfinus dolfinus force-pushed the feature/DOP-22578-datasets branch from 9f1eb00 to b521950 Compare February 13, 2025 08:31
@dolfinus dolfinus enabled auto-merge (rebase) February 13, 2025 08:31
@dolfinus dolfinus merged commit a874b07 into develop Feb 13, 2025
11 checks passed
@dolfinus dolfinus deleted the feature/DOP-22578-datasets branch February 13, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants