Skip to content

[DOP-29593] Add more filters in GET /v1/runs endpoint#323

Merged
dolfinus merged 1 commit intodevelopfrom
feature/DOP-29593
Oct 2, 2025
Merged

[DOP-29593] Add more filters in GET /v1/runs endpoint#323
dolfinus merged 1 commit intodevelopfrom
feature/DOP-29593

Conversation

@dolfinus
Copy link
Member

@dolfinus dolfinus commented Oct 2, 2025

Change Summary

Filter by ended_at is quite effective is value range is small (e.g. 5-10 minutes), even if there is no index for this field in the table. Filter by started_at is added for symmetry.

Also added filters job_location_id and started_by_user to allows fetching only jobs started on specific cluster/host by specific users - this also reduces number of fetched runs.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus requested a review from TiGrib October 2, 2025 08:43
@dolfinus dolfinus self-assigned this Oct 2, 2025
@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Coverage

Coverage Report •
FileStmtsMissCoverMissing
data_rentgen/db/repositories
   run.py1092973%223–224, 226–227, 229, 231, 239, 242–243, 245–246, 253–254, 257–260, 263–264, 267, 282–284, 292, 309–311, 313–314
data_rentgen/server/services
   run.py51198%71
TOTAL702039794% 

@dolfinus dolfinus marked this pull request as ready for review October 2, 2025 08:51
@dolfinus dolfinus changed the title [DOP-29593] Add filter by Run.started_at and Run.ended_at [DOP-29593] Add more filters in GET /v1/runs endpoint Oct 2, 2025
@dolfinus dolfinus merged commit 90e9d7a into develop Oct 2, 2025
11 checks passed
@dolfinus dolfinus deleted the feature/DOP-29593 branch October 2, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants