[DOP-22133] Implement increment for transfers with file sources#209
Merged
IlyasDevelopment merged 1 commit intodevelopfrom Feb 27, 2025
Merged
[DOP-22133] Implement increment for transfers with file sources#209IlyasDevelopment merged 1 commit intodevelopfrom
IlyasDevelopment merged 1 commit intodevelopfrom
Conversation
a2187b5 to
2d56c8d
Compare
2d56c8d to
1ca78aa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #209 +/- ##
===========================================
+ Coverage 91.95% 91.97% +0.01%
===========================================
Files 189 192 +3
Lines 4611 4695 +84
Branches 335 345 +10
===========================================
+ Hits 4240 4318 +78
- Misses 293 295 +2
- Partials 78 82 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dolfinus
reviewed
Feb 24, 2025
dolfinus
reviewed
Feb 24, 2025
dolfinus
reviewed
Feb 24, 2025
1ca78aa to
a1d31bf
Compare
a1d31bf to
2cbc188
Compare
dolfinus
reviewed
Feb 25, 2025
dolfinus
reviewed
Feb 25, 2025
dolfinus
reviewed
Feb 25, 2025
dolfinus
reviewed
Feb 25, 2025
dolfinus
reviewed
Feb 25, 2025
dolfinus
reviewed
Feb 25, 2025
2cbc188 to
ff45600
Compare
ff45600 to
7c58e7b
Compare
dolfinus
reviewed
Feb 25, 2025
dolfinus
reviewed
Feb 25, 2025
7c58e7b to
eae180b
Compare
Member
|
LGTM, but SFTP tests are failing, please check |
eae180b to
9558cf1
Compare
dolfinus
approved these changes
Feb 25, 2025
9558cf1 to
b9c0c72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
FileDownloaderfor incremental transfer withFileModifiedTimeHWM, using a unique name composed oftransfer.id,transfer.source_connection.name, andtransfer.source_params.directory_pathHWMStorefor existing HWM. If absent orstrategy=full,FileDFWriteris initialized withif_exists="replace_overlapping_partitions"orif_exists="replace_entire_table". Otherwise,if_exists="append"is used to prevent duplicatesIncrementalStrategy()contextStrategy.increment_by=file_namewithFileListHWMfor FTP/FTPSChecklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rstfile added describing change(see CONTRIBUTING.rst for details.)