Implement direction-independent calibration in peel subcommand#65
Draft
Implement direction-independent calibration in peel subcommand#65
Conversation
Author
|
@d3v-null 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: d3v-null <2578076+d3v-null@users.noreply.github.com>
Co-authored-by: d3v-null <2578076+d3v-null@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Peel doesn't peel
Implement direction-independent calibration in peel subcommand
Aug 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements full "peeling" functionality in the peel subcommand by adding direction-independent (DI) calibration capabilities. Previously, the peel subcommand only performed ionospheric subtraction. Now it can perform complete peeling, which includes both ionospheric subtraction and DI calibration toward bright sources.
Key Changes
New CLI Arguments
--peel N: Specify number of brightest sources to fully peel (DI calibrate)--di-max-iterations: Maximum DI calibration iterations (default: 50)--di-stop-threshold: DI calibration stop threshold (default: 1e-8)--di-min-threshold: DI calibration minimum threshold (default: 1e-4)Parameter Validation
The hierarchy of source processing is now:
--peel ≤ --iono-sub ≤ --num-sourcesImplementation Details
--peelcountcalibrate_timeblockfunction from thedi_calibratemoduleUsage Examples
What's the Difference?
Ionospheric Subtraction (
--iono-sub):Full Peeling (
--peel):Current Limitations
The DI calibration solutions are computed and validated but not yet fully applied to the visibility data. This is marked as a TODO for future enhancement. The current implementation demonstrates the calibration convergence and provides the foundation for complete solution application.
Fixes #61.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.