Open
Conversation
Owner
|
Thanks for submitting the PR! I've been cautious of adding more features to the template, as it is already hard for people to wrap their heads around. I do appreciate that this is simple/concise, though. I hardly ever run the games from the command line, so I would wait to see if this feature gets requested more before merging it in. I hope you don't mind if I leave it open for a few months. |
Contributor
Author
|
Yeah that's fine. It's more targeted for steam releases, where you can manually set launch arguments trough steams UI. Many games ship with that so I thought it might be neat to add this :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
this project is great and I've used it multiple times now :)
This PR adds a small quality of life feature for the players. They can add
--skip-introsto their launch arguments to skip the opening intros in case they want that :)Have nice day!