-
Notifications
You must be signed in to change notification settings - Fork 872
Set up pre-commit hooks #2283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up pre-commit hooks #2283
Conversation
|
For comparison: The lint step using the pre-commit hooks (without installing BERTopic itself) took 22 seconds, whereas the lint job (with installing BERTopic and dev dependencies) took 3m 11s. |
Sounds good.
Ah, I was wondering why there were suddenly so many changes!
Yeah, considering this influences the tests, let's fix them here, thanks! |
4473605 to
a5b10bd
Compare
|
A pre-commit hook wants to add a newline to the HTML files. Accept or ignore? |
Let's ignore that one. |
a5b10bd to
d808169
Compare
|
All done. Rebased to master. |
|
Thank you again for your work on this. It is highly appreciated!! |
What does this PR do?
Fixes #2274
I used the same config like the KeyBERT repo, but updated the hooks versions. Should the extra lint ci job be removed? I did not want to remove it without asking for permission.
This now leads to a lot of "trailing whitespace" fixes. Also there are a few findings from ruff.
Do you want (me) to fix those in this PR?
end-of-file-fixerhookBefore submitting