-
Notifications
You must be signed in to change notification settings - Fork 872
Add langchain embedder #2303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add langchain embedder #2303
Conversation
|
Thanks for the PR! There was an odd error with the GH-workflow, so I reran the checks. That said, I think we can skip adding LangChain to the pyproject.toml for two reasons. First, there are no tests, so I cannot guarantee that a given version will work. Second, considering the LangChain would have you install additional dependencies anyway (depending on the embedding model), doing |
|
Sure, I have just removed all changes on the |
|
Awesome, it seems that it is working well. Would you mind adding a small section to the documentation? Above flair would be nice considering most users would want to use sbert/transformers first. It doesn't have to be much, so just the docstrings and a few lines to explain what LangChain is and where to find/install it. |
9a89d57 to
9111fb5
Compare
|
Thanks for adding the docs, after the conflicts have been resolved and the tests pass then I'll go ahead and merge this. |
6479c72 to
37d1721
Compare
|
I have just rebased the branch as I see FastEmbed has been added recently. Let's see if it's passing the tests. |
|
Awesome, thank you for your thoughtful work on this and your quick replies. Great to have this in BERTopic. |
What does this PR do?
This PR adds a Langchain Embeddings class as the backend of BERTopic. The Langchain Backend supports LangChain compatable
Embeddings, including 3rd party integration.Github Issue
#2293
Before submitting