Update to pass precomputed embeddings to KeyBERTInspired.extract_topics#2368
Merged
MaartenGr merged 13 commits intoMaartenGr:masterfrom Jun 6, 2025
Merged
Update to pass precomputed embeddings to KeyBERTInspired.extract_topics#2368MaartenGr merged 13 commits intoMaartenGr:masterfrom
MaartenGr merged 13 commits intoMaartenGr:masterfrom
Conversation
MaartenGr
reviewed
May 30, 2025
Owner
MaartenGr
left a comment
There was a problem hiding this comment.
Thank you for the PR! I left a few small comments but otherwise it is looking good.
Owner
|
Awesome, thank you for your work on this! It's great to have this feature in BERTopic. |
Contributor
Author
|
Happy to contribute. Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR essentially passes the precomputed embeddings to extract_topics method of KeyBERTInspired to avoid re computing embeddings of documents.
Fixes # #2367
Before submitting