Re-export CHROME_STORAGE_TYPE as value instead of type#63
Merged
MacFJA merged 1 commit intoMacFJA:mainfrom Jun 29, 2025
Merged
Conversation
Owner
|
Thanks for the fix! The CI is failing, but it's not your code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I've been using your library since 2024, it's very nice!
Today I went to build a small web extension with it (targeting Firefox primarily, where
chromeis supported but it has also been redefined under the genericbrowserAPI) and couldn't import CHROME_STORAGE_TYPE as a value to use it like in the docs example because the enum was exported as a type. This fixes that.Thank you for sharing the code!