Bump versions of mathic, etc. #4059
Draft
+43
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-torrance
force-pushed
the
mathic-etc
branch
9 times, most recently
from
1a878f1 to
3eff98c
Compare
d-torrance
commented
Dec 23, 2025
|
|
||
| # C++ compiler flags | ||
| set(CXXFLAGS "${COMPILEFLAGS} -std=gnu++11 -w -Wno-mismatched-tags -Wno-deprecated-register") | ||
| set(CXXFLAGS "${COMPILEFLAGS} -std=gnu++11 -w -Wno-mismatched-tags -Wno-deprecated-register ${CMAKE_CXX_FLAGS}") |
Member
Author
There was a problem hiding this comment.
@mahrud -- Is there a better way to get CXXFLAGS from the environment and pass them to the various library builds? (We need them for frobby, and I imagine some other C++ dependencies, when building with brew clang or we get a linking error.)
Also, do we still need the various hard-coded flags?
No longer need to override INSTALLCMD as "make install" does the right thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in the process of tagging new releases for several of our dependencies for which we're upstream: