Fix garbage collection of foreign gmp/mpfr objects #4080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GC finalizer callback function expects two parameters: a pointer to the GC memory we're finalizing and a pointer to some client data. We were previously passing the *first* object to mpz_clear and mpfr_clear, which was incorrect. (This is why the mpfr code was commented out, as otherwise we were segfaulting trying to call mpfr_clear on our pointer object rather than on the mpfr_ptr it's pointing to!. I'm surprised the gmp code wasn't segfaulting too!)
Member
|
I'm a bit confused, did mpfr just not finalize at all before? Is it possible to add some sort of test or memory benchmark to compare with previous performance? |
Member
Author
|
That's correct -- I guess I gave up too soon trying to figure out why it was segfaulting... I just added a test that creates a bunch of these objects and then collects the garbage. Is that the kind of thing you were asking for? I'm not sure of a good way to check if we actually finalized the things we wanted to. |
Contributor
|
This applies to ffi related objects only right? Everything else the engine does that I know of reallocates the limbs into gc memory. |
Member
Author
|
Yes, that's correct. Only objects of class |
Member
Author
|
Discussed with Mike |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GC finalizer callback function expects two parameters: a pointer to the GC memory we're finalizing and a pointer to some client data. We were previously passing the first object to
mpz_clearandmpfr_clear, which was incorrect. (This is why the mpfr code was commented out, as otherwise we were segfaulting trying to callmpfr_clearon our pointer object rather than on thempfr_ptrit's pointing to!. I'm surprised the gmp code wasn't segfaulting too!)