feat: implement sort_order support for groups in API responses #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add SortOrder property to GroupDto class - Update StatusService, EndpointService, and HistoryService to include SortOrder in GroupDto mappings - Fix StatusService sorting to use Group.SortOrder instead of GroupId - Implement proper group ordering: SortOrder (nulls last), then Name - Ensure all API responses (live status, endpoints, history) include sort_order values - Groups without sort_order will appear last in UI lists 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Fix JSON schema to allow null values for color and sort_order fields - Update both server and test schema files to use ["string", "null"] for color - Update sort_order to allow ["integer", "string", "null"] values - Resolves validation failures when saving groups without optional fields 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…ation - Create OptionalRegularExpressionAttribute that properly handles null/empty values - Replace RegularExpression attribute with custom attribute for Color field - Allows groups to be saved without color field while validating hex format when present - Fixes validation failures when optional fields (color, sort_order, parent_id) are missing 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
SortOrderproperty toGroupDtoGetLiveStatusAsyncand group cachingTest Plan
Impact
sort_orderdefined in YAML configuration will now be properly ordered in UIsort_orderwill appear last (sorted by name)🤖 Generated with Claude Code