Skip to content

Feat/refactor lut crt#6

Merged
rkdud007 merged 7 commits intomainfrom
feat/refactor_lut_crt
Aug 11, 2025
Merged

Feat/refactor lut crt#6
rkdud007 merged 7 commits intomainfrom
feat/refactor_lut_crt

Conversation

@SoraSuegami
Copy link
Member

This PR

  1. generalizes the concrete logics behind the lookup evaluation on BGG+ encodings because we will support multiple logics.
  2. removes the number of lookup tables from 4 to 2 in BigUintPoly.

@SoraSuegami SoraSuegami requested a review from rkdud007 August 10, 2025 23:10
@SoraSuegami SoraSuegami marked this pull request as draft August 11, 2025 02:30
@SoraSuegami SoraSuegami marked this pull request as ready for review August 11, 2025 02:54
@rkdud007
Copy link
Collaborator

just for note, now we have mxx and diamond-io two different repo, which these refactoring make breaking change on other repo that depends on it - i've made PR here so merging it together (which made it here: MachinaIO/diamond-io#156)

@rkdud007
Copy link
Collaborator

Also I don't think with we should lookup as directory name for all PLT logic cus we probably want to have public lookup and also private lookup later but it's nit pick so leaving for now

@rkdud007 rkdud007 merged commit 4a65ca6 into main Aug 11, 2025
1 of 3 checks passed
@rkdud007 rkdud007 deleted the feat/refactor_lut_crt branch August 11, 2025 19:20
rkdud007 added a commit to MachinaIO/diamond-io that referenced this pull request Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants