Fix evaluation KeyError for "eval_one_score" and model loading issue for ModernBERT#227
Closed
ianbulovic wants to merge 3 commits intoMachine-Learning-for-Medical-Language:mainfrom
Closed
Conversation
ianbulovic
changed the title
Contributor
Author
|
Tests are passing but ModernBERT is broken again... |
Contributor
|
superseded by #228 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following error during evaluation:
KeyError: "The `metric_for_best_model` training argument is set to 'eval_one_score', which is not found in the evaluation metrics.Looking back at the discussion in #190, there was some concern about saving the model twice. Not sure if this is still an issue...
This also fixes an issue that was causing the final best model load at the end of training to fail for ModernBERT fine-tuning.