Deploy cephfs pods in rook-ceph namespace instead of default namespace#2
Open
poornimag wants to merge 81 commits intoMadhu-1:masterfrom
Open
Deploy cephfs pods in rook-ceph namespace instead of default namespace#2poornimag wants to merge 81 commits intoMadhu-1:masterfrom
poornimag wants to merge 81 commits intoMadhu-1:masterfrom
Conversation
csi-attacher and csi-provisioner change from v1.0.0 to v1.0.1, as i the v1.0.0 is a Pre-release driver-registrar:v1.0.0 change to csi-node-driver-registrar:v1.0.2, as in CSI Spec v1.0.0, image name has changed, see [https://github.com/kubernetes-csi/node-driver-registrar#compatibility](https://github.com/kubernetes-csi/node-driver-registrar#compatibility)
merge csiv1.0 branch to master
currently we are deploying external-attacher as a seperate statefulset, which leads to attacher communicating with the node provisoner daemonset, This PR deploys external-attacher as a sidecar container inside provisioner statefulset, so that external-provisioner always communicates with the plugin responsible for the provision controller capcabilities. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
…isioner pod Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
… pod Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
…rovisioner. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
adding the condition will help us to easily remove the attacher later. or even we can add else condition if we have an alternate to attacher. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
if attacher is not enabled, we need to create the csidriver CRD with spec to make attachRequired as false to skip volume attach check in kube. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Add link to go-report card and travis build status in readme file. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Replaces the references to Kubernetes Authors in the copyright
add go-report card and travis status
Deploy csi-attacher as sidecar container in provisioner statefulset
Create a single binary that can start ceph-csi in either rbd or cephfs mode. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Add rules and variables to the Makefile so that the unified binary and container image can be built. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Create a single binary that can start ceph-csi in either rbd or cephfs mode. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Add rules and variables to the Makefile so that the unified binary and container image can be built. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
fix helm value pullPolicy mismatch bug
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
deploy.sh was using ENV vars to set the image versions incorrectly. This causes the images to be pushed using versions already in the Makefile, rather than the overrides in the deploy script. This is now fixed by updating the right ENV variables. Signed-off-by: ShyamsundarR <srangana@redhat.com>
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Merge csi v1.0 to master
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
update v1.0.0-canary tag to canary tag Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Signed-off-by: hchiramm <hchiramm@redhat.com>
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Signed-off-by: Poornima G <pgurusid@redhat.com>
Minor reorg of README contents. Also calling out alpha status of the plugins. Signed-off-by: ShyamsundarR <srangana@redhat.com>
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Signed-off-by: Poornima G <pgurusid@redhat.com>
Fix issues in e2e to be able to run it succesfully
Signed-off-by: Poornima G <pgurusid@redhat.com>
Madhu-1
pushed a commit
that referenced
this pull request
Jul 1, 2021
rebase: prevent building go-ceph/snapshot_octopus.go (downstream only)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thought this was necessary for fixing some test failures, i think secrets or(?) gets deployed in the rook-ceph namespace and ceph provisioners get deployed in default namespace was causing some failures