Skip to content

Conversation

@khassel
Copy link
Collaborator

@khassel khassel commented May 16, 2025

This is a draft PR for creating the container image in this repo.

We have to discuss if we want to move the build from gitlab into this repo.

I created an image on my fork which works:

  • image: docker pull ghcr.io/khassel/magicmirror-3rd-party-modules:main
  • job log

I'm not really convinced of github actions but it would be a cleaner setup to do the build here.

Disadvantages (so far):

  • github actions cron has still no timezone support

@KristjanESPERANTO
Copy link
Collaborator

I am open to all options. But yes, it appears to be cleaner to do the build here 🙂

@KristjanESPERANTO KristjanESPERANTO changed the title add container build ci: add container build May 17, 2025
@khassel
Copy link
Collaborator Author

khassel commented May 18, 2025

so let us merge this ...

After merge and first successful build I will change to the new image (build here) in our mm-server setup.

@khassel khassel marked this pull request as ready for review May 18, 2025 20:35
@khassel khassel requested a review from KristjanESPERANTO May 18, 2025 20:35
@KristjanESPERANTO KristjanESPERANTO merged commit 9b979f4 into MagicMirrorOrg:main May 19, 2025
2 checks passed
@khassel khassel deleted the build branch May 21, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants