-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
update Collaboration.md and dependencies #4001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
What is the xxxxx NPM_TOKEN=npm_xxxxx |
|
I dont like bypassing 2FA, more when I am back at my desk during the weekend
Am 1. Januar 2026 23:03:10 MEZ schrieb Karsten Hassel ***@***.***>:
…
You can view, comment on, or merge this pull request online at:
#4001
-- Commit Summary --
* update Collaboration.md and dependencies
-- File Changes --
M Collaboration.md (12)
M package-lock.json (79)
M package.json (4)
-- Patch Links --
https://github.com/MagicMirrorOrg/MagicMirror/pull/4001.patch
https://github.com/MagicMirrorOrg/MagicMirror/pull/4001.diff
--
Reply to this email directly or view it on GitHub:
#4001
You are receiving this because you are subscribed to this thread.
Message ID: ***@***.***>
|
I described only one way to get Please consider that I have no node/npm stuff on my working system (windows) so I have to do this per command line in a linux container which has no browser. Let me know how to do this with 2FA. Or better change the content of Collaboration.md in this PR. |
|
I also have no npm content other than MM, |
Without a browser it indeed could be tricky. When I publish on npm (via console), it does open a brwoser for me and I can enter my 2fa code there. Maybe add your setup (with the NPM_TOKEN instrcutions) as a secondary way for publishing (one with brwoser, one without brwoser)? |
|
as I already mentioned: I know only the method I wrote down in Collaboration.md. If you prefer a method with 2fa write it down and commit it into this PR. Leaving my method as secondary would be helpful if the 2fa-method is not usable in headless setups. |
- Method 1 (recommended): npm login with browser and 2FA - Method 2 (fallback): token-based for headless environments - Add security warning for token method that bypasses 2FA
|
I've just added a commit (b73aa21) with both methods for npm publishing. This should address both @rejas' security concerns and @khassel's headless setup requirements. The 2FA method is clearly marked as recommended, while the token method remains available as a documented fallback for environments without browser access. What do you think? 🙂 |
|
Thanks @KristjanESPERANTO , can't approve (because I created this PR) but I'm fine with this. |
|
npm login worked for me just now |
Because you probably chose the "bypass 2FA option" and saved the token. The problem with the bypass is that if one of those systems with bypass are getting compromised, malicious code could be easily published via npm. There have already been npm dependency chain attacks, so it's not entirely unrealistic. |
I know about the npm problems. When I do the |
|
It asked me to login with my passkey |

No description provided.