Skip to content

tests: Attempt to inhibit spurious ConnectionResetError on Windows #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2024
Merged

tests: Attempt to inhibit spurious ConnectionResetError on Windows #1190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions asyncpg/_testbase/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,10 +117,22 @@ def setUp(self):
self.__unhandled_exceptions = []

def tearDown(self):
if self.__unhandled_exceptions:
excs = []
for exc in self.__unhandled_exceptions:
if isinstance(exc, ConnectionResetError):
texc = traceback.TracebackException.from_exception(
exc, lookup_lines=False)
if texc.stack[-1].name == "_call_connection_lost":
# On Windows calling socket.shutdown may raise
# ConnectionResetError, which happens in the
# finally block of _call_connection_lost.
continue
excs.append(exc)

if excs:
formatted = []

for i, context in enumerate(self.__unhandled_exceptions):
for i, context in enumerate(excs):
formatted.append(self._format_loop_exception(context, i + 1))

self.fail(
Expand Down
Loading